fix: Community-Operator - Fight with external Pod mutations #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Galos <[email protected]>
MaciejKaras
reviewed
Aug 30, 2025
| // WithPodLabels merges the provided labels with existing PodTemplateSpec labels. | ||
| // This preserves labels added by external systems (like Kyverno policies) while | ||
| // allowing the operator to add or override its own labels. | ||
| func WithPodLabels(labels map[string]string) Modification { |
There was a problem hiding this comment.
I see you have removed WithInitContainerByIndex but it is still used in the codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR mitigates runtime operator fights between mutators of the Pods generated by the MongoDB StatefulSet and the MongoDB Community Operator.
It preserves previous labels instead of hard-coding them. The previous logic of adding the
applabel is kept as-is. The MongoDB operator can still overwrite labels it wants to have in a specific form.All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Closes: mongodb/mongodb-kubernetes-operator#1732.